Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display Total Account Value #246

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Display Total Account Value #246

wants to merge 2 commits into from

Conversation

rnevet
Copy link
Collaborator

@rnevet rnevet commented Feb 28, 2017 •
edited by Evanito
Loading

Display total account value (Lending, Margin, Exchange) in BTC and Output currency

Description

Implements issue #240
Closes #240

TESTING STAGE

In progress

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have read CONTRIBUTING.md
  • I fully understand Github Flow.
  • My code adheres to the code style of this project.
  • I have updated the documentation in /docs if I have changed the config, arguments, logic in how the bot works, or anything that understandably needs a documentation change.
  • I have updated the config file accordingly if my change requires a new configuration setting or changes an existing one.
  • I have tested the bot with no issues for 24 continuous hours. If issues were experienced, they have been patched and tested again.

@rnevet
Fetch total account balance and store in JSON
d32481a 
Implemented API method return_complete_balances
Added a call in bot loop for fetching complete balance
Sum coins balance and store in json output
@rnevet
Added Account Balance
ff70c5b
@rnevet rnevet self-assigned this Feb 28, 2017
@rnevet
Copy link
Collaborator Author

rnevet commented Feb 28, 2017

TODO:
Add configuration option to enable/disable the bot from adding this information to the output.

@Evanito
Copy link
Member

Evanito commented Mar 7, 2017

Looks good so far, will test and review when you are done.

@rnevet rnevet mentioned this pull request Apr 3, 2017
Merged
12 tasks
@tamaskan tamaskan mentioned this pull request Jun 3, 2017
Merged
6 tasks
@bkuhl
Copy link

bkuhl commented Apr 25, 2018

Being over a year old.... is this still in progress or is it time to close it?

@utdrmac
Copy link
Contributor

utdrmac commented Jul 3, 2018 •
edited
Loading

@rnevet Missing Bitfinex support. Tough because Bitfinex does not return 'btcValue' like Polo does. Have to convert each coin using latest market data.

@utdrmac
Copy link
Contributor

utdrmac commented Jul 6, 2018

Tried writing a quick patch for Bitfinex. Seems more trouble than it's worth. You'd have to add any/all coins back into all_currencies if you want the values calculated because Bitfinex does not return the estimated BTC value like polo does. So you have to first fetch all coin balances from each account type, fetch individual tickers for each coin (or use v2 API which allows requesting multiple), then calculate each coin's value. I had this somewhat working but my patch caused lending to stop so I gave up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RemyMalaya RemyMalaya RemyMalaya approved these changes

At least 1 approving review is required to merge this pull request.

Assignees

@rnevet rnevet

Labels
Enhancement In Progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add total account value to summary page
5 participants
@rnevet @Evanito @bkuhl @utdrmac @RemyMalaya